RANGER-5212: Search filter in Roles tab does not consider all relevant role columns - #580
Merged
Merged
Conversation
dhavaljrajpara
requested review from
dhavaljrajpara,
dineshkumar-yadav,
mneethiraj and
pradeepagrawal8184
May 28, 2025 05:48
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends the existing “Role Name” filter so that it also searches values in the sub-role (Associated Role) column.
- Adds a new “Associated Role” text filter to the Roles tab UI
- Registers
subRoleNameandsubRoleNamePartialin the service search fields and request parameter mapping - Hooks the new filters into the backend predicate logic
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| security-admin/.../RoleListing.jsx | Added new UI filter object for Associated Role |
| security-admin/.../RangerRoleServiceBase.java | Registered full and partial sub-role search fields |
| security-admin/.../RangerSearchUtil.java | Mapped HTTP parameters for sub-role filters |
| agents-common/.../SearchFilter.java | Defined constants for subRoleName filters |
| agents-common/.../RolePredicateUtil.java | Added predicate calls for new sub-role filters |
dhavaljrajpara
approved these changes
Sep 2, 2025
dhavaljrajpara
left a comment
dhavaljrajpara
left a comment
Contributor
There was a problem hiding this comment.
UI changes are approved
RakeshGuptaDev
force-pushed
the
RANGER-5212_master
branch
from
September 2, 2025 13:15
25beaa5 to
90334f1
Compare
RakeshGuptaDev
force-pushed
the
RANGER-5212_master
branch
from
December 16, 2025 14:01
90334f1 to
bdeacf4
Compare
mneethiraj
reviewed
Dec 29, 2025
RakeshGuptaDev
force-pushed
the
RANGER-5212_master
branch
from
December 30, 2025 10:38
bdeacf4 to
971a896
Compare
mneethiraj
approved these changes
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When using the Role Name filter, it only matches values from the Role Name column. It does not match values from the Roles column, even though that column contains the role for Role Admin and Role Auditor
How was this patch tested?
Verify that the 'Role Name' filter retrieves all matching records, regardless of whether the value resides in the 'Role Name' column or the 'Roles' column.